Skip to content

HDFS-16687. RouterFsckServlet replicates code from DfsServlet base class#4681

Merged
goiri merged 1 commit intoapache:trunkfrom
snmvaughan:feature/HDFS-16687-2
Aug 3, 2022
Merged

HDFS-16687. RouterFsckServlet replicates code from DfsServlet base class#4681
goiri merged 1 commit intoapache:trunkfrom
snmvaughan:feature/HDFS-16687-2

Conversation

@snmvaughan
Copy link
Contributor

@snmvaughan snmvaughan commented Aug 3, 2022

Description of PR

RouterFsckServlet replicates the method "getUGI(HttpServletRequest request, Configuration conf)" from DfsServlet instead of just extending DfsServlet. This change is just a refactor, which replaces the copy with the original base class.

How was this patch tested?

The fsck endpoint was called using curl, verifying that the Kerberos checks performed as expected.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

HDFS-16687. RouterFsckServlet replicates code from DfsServlet base class
ce27208 
Extend DfsServlet instead of replicating the code.
sunchao
sunchao approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @goiri

@hadoop-yetus
Copy link

hadoop-yetus commented Aug 3, 2022

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 57s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 41m 37s trunk passed
+1 💚 compile 1m 0s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 compile 0m 56s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 0m 52s trunk passed
+1 💚 mvnsite 1m 3s trunk passed
+1 💚 javadoc 1m 9s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 1m 14s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 1m 48s trunk passed
+1 💚 shadedclient 21m 19s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 42s the patch passed
+1 💚 compile 0m 43s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javac 0m 43s the patch passed
+1 💚 compile 0m 39s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 0m 39s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 26s the patch passed
+1 💚 mvnsite 0m 44s the patch passed
+1 💚 javadoc 0m 41s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 0m 59s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 1m 27s the patch passed
+1 💚 shadedclient 20m 45s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 36m 23s hadoop-hdfs-rbf in the patch passed.
+1 💚 asflicense 0m 53s The patch does not generate ASF License warnings.
138m 25s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4681/1/artifact/out/Dockerfile
GITHUB PR #4681
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 4f9bca76972b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / ce27208
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4681/1/testReport/
Max. process+thread count 2780 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4681/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ZanderXu
ZanderXu approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@ZanderXu ZanderXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@goiri goiri merged commit 0fc7dd8 into apache:trunk Aug 3, 2022
snmvaughan added a commit to snmvaughan/hadoop that referenced this pull request Aug 22, 2022
@snmvaughan
HDFS-16687. RouterFsckServlet replicates code from DfsServlet base cl…
5284fe9 
…ass (apache#4681)
sunchao pushed a commit that referenced this pull request Aug 23, 2022
@snmvaughan
HDFS-16687. RouterFsckServlet replicates code from DfsServlet base cl…
a73efb2 
…ass (#4681) (#4790)
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
@snmvaughan
HDFS-16687. RouterFsckServlet replicates code from DfsServlet base cl…
a2a500b 
…ass (apache#4681)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunchao sunchao sunchao approved these changes

@goiri goiri goiri approved these changes

@ZanderXu ZanderXu ZanderXu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@snmvaughan @hadoop-yetus @sunchao @goiri @ZanderXu